Will there be official support for Rails >= 2.3

[russ816]

I got around to cleaning it up a bit. I'm sure there are other issues, so I just put it up on github for fixes.

http://github.com/russ/litespeed-rai...er/tree/master

[mistwang]

That's good.

I think we still need to support older release of Rails and only use that for 2.3 and above.

In the code

ActiveRecord::Base.clear_active_connections! if defined?(ActiveRecord::Base)

may not work well unless the function has been added back in, seems it is missing in latest rails 2.2 release.
That's why we need to update RailsRunner.rb to discount and reconnect the connection manually in the latest version.

[mistwang]

Looks like

ActiveRecord::Base.clear_active_connections!

is coming back into ActiveRecord::Base in rails 2.3, so it should be fine.
I have to make the RailsRunner.rb compatible with Rails 1.x 2.2 and 2.3 by combining the current RailsRunner.rb and the one you put up on github.

Is there any easy way to detect the Rails version being used at the beginning?

[mistwang]

I am thinking adding ruby code to extract the version number from file "RAILS_ROOT/config/environment.rb, at the beginning of the file,
"RAILS_GEM_VERSION" is set to the version of Rails should be used.

Can anyone help with the ruby code?

[kule]

Originally Posted by mistwang

I am thinking adding ruby code to extract the version number from file "RAILS_ROOT/config/environment.rb, at the beginning of the file,
"RAILS_GEM_VERSION" is set to the version of Rails should be used.

Can anyone help with the ruby code?

If I can help I will - what exactly are you after? Some additions to the github code above? e.g. do you just want to do something like

if RAILS_GEM_VERSION >= 2.3.2
# use rack
else
# use old system
end

or did you want to get the RAILS_GEM_VERSION number out to litespeed?

[mistwang]

I am not sure we can do "require config/environment" at the beginning of the file or not. The code for 2.3 does not have that.
I am thinking about some ruby code to open config/environment.rb and search for RAILS_GEM_VERSION .

[mistwang]

actually, config/boot.rb does exactly what I want. just need to duplicate that code.

[kule]

Originally Posted by mistwang

actually, config/boot.rb does exactly what I want. just need to duplicate that code.

Based on running in the rails root:

environmentrb = File.read('config/environment.rb')
puts $1 if environmentrb =~ /^[^#]*RAILS_GEM_VERSION\s*=\s*["']([!~<>=]*\s*[\d.]+)["']/

If you have loaded rails then you can use:

File.read("#{RAILS_ROOT}/config/environment.rb")

and it'll pull in the full file path too.

Ta
Luke

[mistwang]

I want to save the result in variable "raisl_ver"

environmentrb = File.read('config/environment.rb')
rails_ver = $1 if environmentrb =~ /^[^#]*RAILS_GEM_VERSION\s*=\s*["']([!~<>=]*\s*[\d.]+)["']/

Is above code correct?

[kule]

Originally Posted by mistwang

I want to save the result in variable "raisl_ver"
Is above code correct?

Yep looks good to me.