LSAPI do something wrong with ENV

Discussion in 'Ruby/Rails' started by Grzegorz Derebecki, Nov 9, 2009.

  1. Grzegorz Derebecki

    Grzegorz Derebecki Well-Known Member

    Grrrrr... i spend all my day to fix this bug:

    when we require lsapi gem the ENV var will be lost! In RailsRunner (for 2.3)
    we have:

    server = Rack::Handler::LSWS
    this is rack/lib/rack/handler/lsws.rb and in line 1 we have:

    require 'lsapi'
    after this require ENV varible will be empty.

    Some rails plugins use ENV['RAILS_ENV'] or other ENV varibles exemple: Thinking Sphinx is initialized early and use ENV['RAILS_ENV'] if it is not set it use 'devalopment' mode even if i'm on production.

    Ok how to fix it? I don't like C.. then i fixed it in RailsRunner:

    env = ENV
    server = Rack::Handler::LSWS
    env.each { |k,v| ENV[k] ||= v }
    i used this syntax becous if in future it start works correctly it want broken anything :)
  2. mistwang

    mistwang LiteSpeed Staff

    Thanks for the bug report and fix. We will take a look at this issue.

Share This Page